Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jigsaw enable UCUM #153

Closed
keilw opened this issue Oct 20, 2019 · 2 comments
Closed

Jigsaw enable UCUM #153

keilw opened this issue Oct 20, 2019 · 2 comments

Comments

@keilw
Copy link
Member

keilw commented Oct 20, 2019

While all other modules were already exposed in Jigsaw form via #152 as part of 2.0 there are some dependencies mostly formatting exceptions in the UCUM part that require changes in the RI, like moving those exceptions to visible packages.

Needs unitsofmeasurement/indriya#269

@keilw
Copy link
Member Author

keilw commented Jan 13, 2020

Using the UCUM module via "Jigsaw" causes this problem:

Error occurred during initialization of boot layer
java.lang.module.ResolutionException: Module systems.uom.ucum contains package tech.units.indriya.format, module tech.units.indriya exports package tech.units.indriya.format to systems.uom.ucum

The reason is the messages.properties file which more or less duplicates UCUMFormat_Print.properties. There seems no way to make the RI formatting system aware of UCUM units without enhancements to the RI.

@keilw keilw added the bug label Jan 13, 2020
@keilw
Copy link
Member Author

keilw commented Jan 13, 2020

For 2.1 we'll deactivate the properties by putting them into a different folder/package. Based on unitsofmeasurement/indriya#270 in a follow-up release (probably 2.1) such a folder could be picked up again by Indriya allowing extension of the RI formatters again.

keilw added a commit to unitsofmeasurement/uom-demos that referenced this issue Apr 5, 2020
keilw added a commit to unitsofmeasurement/uom-demos that referenced this issue Apr 19, 2020
@keilw keilw modified the milestones: 2.0.2, 2.1 May 27, 2020
keilw added a commit that referenced this issue May 27, 2020
@keilw keilw modified the milestones: 2.1, 2.0.2 May 28, 2020
keilw added a commit that referenced this issue May 28, 2020
keilw added a commit to unitsofmeasurement/unit-api that referenced this issue Jun 4, 2020
@keilw keilw closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant