Repository navigation
Conversation
TeleImage.__iter__ documents unpacking as `jpg, bgr, fps = teleimage_instance` but yielded fps, jpg, bgr. Following the documented order therefore bound every variable to the wrong value (jpg got the fps float, bgr got the jpg bytes, fps got the decoded image). Yield jpg, bgr, fps to match the docstring and the __slots__ order ['jpg', '_bgr', 'fps'].
winklemad
force-pushed
the
fix/teleimage-iter-order
branch
from
September 4, 2026 20:13
ad50b1c to
aa21be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TeleImage.__iter__documents tuple-unpacking as:""" Allow unpacking like: jpg, bgr, fps = teleimage_instance """but yields the fields in a different order:
So a user who follows the documented usage gets every value bound to the wrong field:
Fix
Yield
jpg, bgr, fpsso__iter__matches its own docstring. This also matches the field order declared in__slots__ = ['jpg', '_bgr', 'fps']; the previous order followed the__init__parameter order(fps, jpg, bgr)instead.After the change,
jpg, bgr, fps = imgbinds each name correctly.If the intended contract was actually
fps, jpg, bgr, the alternative fix would be to update the docstring instead — happy to switch to that if you prefer, but the__slots__order suggestsjpg, bgr, fpswas intended.