Fix missing future covariates error in historical_forecasts/backtest - #3193
Open
webzuweb wants to merge 1 commit into
Open
Fix missing future covariates error in historical_forecasts/backtest#3193webzuweb wants to merge 1 commit into
webzuweb wants to merge 1 commit into
Conversation
Raise a clear ValueError when a model trained with past/future covariates is passed to historical_forecasts()/backtest() without the corresponding covariates, instead of a cryptic IndexError. Closes unit8co#2846
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2846.
When a model is trained with past/future covariates and then passed to
historical_forecasts()/backtest()without the corresponding covariates, the user currently gets a crypticIndexError: index 1 is out of bounds for axis 0 with size 1.This PR adds an explicit
ValueError(mirroring the existing check inpredict()) that clearly states which covariates are missing.Changes
darts/models/forecasting/forecasting_model.py: added early covariate checks inhistorical_forecasts().darts/tests/models/forecasting/test_backtesting.py: addedtest_backtest_missing_future_covariates.Test
pytest darts/tests/models/forecasting/test_backtesting.py::TestBacktesting::test_backtest_missing_future_covariates— passed.