Expose last hidden state on RNNModel and BlockRNNModel - #3190
Open
AmjadAAYD wants to merge 1 commit into
Open
Conversation
Author
|
Checked everything, tests pass locally. CI is waiting on a maintainer to approve the workflow run, standard for a first PR from a new contributor. |
Author
|
Checked everything on my end, tests pass locally. CI hasn't run yet, it needs a maintainer to approve the workflow run since this is my first PR to this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1649. Both models already compute a hidden state internally but discarded it. Now stashed as an attribute on the underlying PyTorch module during forward/predict, and exposed via a last_hidden_state property on both RNNModel and BlockRNNModel (None before first predict/fit). For LSTM this is the (h_n, c_n) tuple, for RNN/GRU a single h_n tensor, matching what the underlying torch module returns. Verified with a real fit+predict on both LSTM and GRU variants of both models, checking shapes and types.