Refactor/use raise log only#3126
Open
dennisbader wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3126 +/- ##
==========================================
- Coverage 96.55% 95.95% -0.60%
==========================================
Files 160 160
Lines 17285 17367 +82
==========================================
- Hits 16689 16664 -25
- Misses 596 703 +107 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jakubchlapek
reviewed
Jun 9, 2026
jakubchlapek
left a comment
Collaborator
There was a problem hiding this comment.
Hey @dennisbader, looks good, thanks for this PR. Two small comments for the code itself, but would also be good to add some tests for the missing lines first :)
Comment on lines
+28
to
+34
| if not isinstance(model, BaseEnsemble): | ||
| raise_log( | ||
| ValueError( | ||
| "Scorer is expecting a model of type BaseEnsemble (from sklearn ensemble), " | ||
| "found type {type(model)}." | ||
| ), | ||
| ) |
Collaborator
There was a problem hiding this comment.
dropped the f-string
Suggested change
| if not isinstance(model, BaseEnsemble): | |
| raise_log( | |
| ValueError( | |
| "Scorer is expecting a model of type BaseEnsemble (from sklearn ensemble), " | |
| "found type {type(model)}." | |
| ), | |
| ) | |
| if not isinstance(model, BaseEnsemble): | |
| raise_log( | |
| ValueError( | |
| f"Scorer is expecting a model of type BaseEnsemble (from sklearn ensemble), " | |
| f"found type {type(model)}." | |
| ), | |
| ) |
Comment on lines
411
to
413
| raise raise_log( | ||
| ValueError("`plot_type` must be either 'all', 'time' or 'heatmap'"), | ||
| logger=logger, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| raise raise_log( | |
| ValueError("`plot_type` must be either 'all', 'time' or 'heatmap'"), | |
| logger=logger, | |
| ) | |
| raise_log( | |
| ValueError("`plot_type` must be either 'all', 'time' or 'heatmap'"), | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #.
Summary
raise_ifandraise_if_notin favor ofraise_log, and maderaise_logautomatically resolve the caller's logger (no longer requires passingloggerexplicitly).