Fix the torch_metric shape error #2786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2786 +/- ##
===========================================
+ Coverage 41.21% 94.50% +53.28%
===========================================
Files 228 145 -83
Lines 35437 15455 -19982
===========================================
- Hits 14607 14605 -2
+ Misses 20830 850 -19980 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dennisbader
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Thanks a lot for fixing this bug @cnhwl, it looks great 🚀 🥳 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #2785.
Summary
Reshape the pred and target regardless of whether
self.n_targets > 1, to satisfy some torch_metrics such as R2Score(preds.ndim <= 2)