Skip to content

Narwhalify_from_group_dataframe #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

cnhwl
Copy link
Contributor

@cnhwl cnhwl commented Apr 9, 2025

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2730.

Summary

A first draft of refactoring the from_group_dataframe() according to #2661. Since I'm not very familiar with the Narwhals library yet, more help would be appreciated!

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.90%. Comparing base (a92fa41) to head (198c321).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
darts/timeseries.py 55.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   43.95%   43.90%   -0.05%     
==========================================
  Files         223      223              
  Lines       33252    33259       +7     
==========================================
- Hits        14617    14604      -13     
- Misses      18635    18655      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dennisbader
Copy link
Collaborator

Hi @cnhwl, and thanks a lot for this PR! We were a bit busy over the last week with the release of Darts 0.35.0.
Next week we should be able to review it :)

@dennisbader
Copy link
Collaborator

dennisbader commented Apr 29, 2025

Hi @cnhwl and thanks for this PR, it's a very good start 🚀

I oushed some updates for this PR:

  • adapt from_group_dataframe() logic to work with polars
  • add polars to from_group_dataframe() tests

The Narwhals team is current fixing an issue related to parallelization using polars DFs wrapped by narwhals (see here). Our tests are expected to fail until then.

I will also have to test how this PR affects the performance of the current from_group_dataframe(). But I'm not too worried.

@cnhwl
Copy link
Contributor Author

cnhwl commented Apr 29, 2025

Hi @cnhwl and thanks for this PR, it's a very good start 🚀

I made some updates locally to finalize the PR:

  • adapt from_group_dataframe() logic to work with polars
  • add polars to from_group_dataframe() tests

I would like to push these changes into your branch. It seems like I don't have permission to do so. Could you grant me access to your forked Darts repository?

Of course! @dennisbader I have been added you as a collaborator on my fork repository 🤝.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narwhalify from_group_dataframe()
2 participants