-
Notifications
You must be signed in to change notification settings - Fork 928
Narwhalify_from_group_dataframe #2766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 43.95% 43.90% -0.05%
==========================================
Files 223 223
Lines 33252 33259 +7
==========================================
- Hits 14617 14604 -13
- Misses 18635 18655 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @cnhwl, and thanks a lot for this PR! We were a bit busy over the last week with the release of Darts 0.35.0. |
Hi @cnhwl and thanks for this PR, it's a very good start 🚀 I oushed some updates for this PR:
The Narwhals team is current fixing an issue related to parallelization using polars DFs wrapped by narwhals (see here). Our tests are expected to fail until then. I will also have to test how this PR affects the performance of the current |
…m_group_dataframe
Of course! @dennisbader I have been added you as a collaborator on my fork repository 🤝. |
Checklist before merging this PR:
Fixes #2730.
Summary
A first draft of refactoring the
from_group_dataframe()
according to #2661. Since I'm not very familiar with the Narwhals library yet, more help would be appreciated!