-
Notifications
You must be signed in to change notification settings - Fork 281
tweak: don't bother synhashing when synhashes would be the same #5718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mitchellwrosen
wants to merge
37
commits into
trunk
Choose a base branch
from
25-05-22-synhash
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,165
−2,137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice! |
aryairani
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What sort of coordination has to happen between merging this PR and the Share one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a "narrowing" step to diff/merge. Previously, we'd compute the syntactic hash of every type and term in a namespace, then perform a diff on those hashes. Now, we avoid computing the syntactic hash of terms and types that we know (by their Unison hash) are equal. This allows us to skip a lot of work for diffs/merges that don't transitively touch a lot of definitions, such as those that contain only new definitions.
Additionally, this PR and speeds up definition loading in general by utilizing branch/names caches that were added recently in
update
work. Previously, we'd load all branches involved from scratch (and that's where the conflicted names check was implemented). But this was always slower than going the other direction – using the pre-builtNames
in theBranch
object as a starting point, and checking it for conflicted names. Sinceupdate
now does something similar, I deleted all of the old slow loading code and reworked the starting point of diff/merge to basically be "given branches that are not conflicted, ...".The merge-as-a-library API was simplified down to just two steps, diff (producing a diffblob) and merge (producing a mergeblob). Previously, there were many more steps of pure functions interspersed with database calls, but now those two steps just take a couple callbacks that load defnitions, names, whatever is needed.
I also deleted (& sort of inlined into Share) the "human diffs" calculation, as only Share uses it, so it doesn't need to be in the UCM side. I switched the "renames" field of the diff to only include "simple" renames (one name to one other name), since that's what we'll (try to) incorporate into merge.
A performance number: computing the diff for a small change to
@unison/base
, which includes an add and an update with 5 or so transitive dependents, used to take 13 seconds, and now takes ~0.2 seconds (and is instantaneous if repeated with the same inputs, because cache).Test coverage
Existing transcripts, and manual testing.