This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Add a project route for Unison Share #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojberg
force-pushed
the
project-route
branch
2 times, most recently
from
57078f7 to
03ca5c2
Compare
Move the perspective routes into 1 route with 2 subroutes: Project with ProjectRoute.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't want Perspective and Definition to be top level routes
Solution
Move the perspective routes into 1 route with 2 subroutes: Project with
ProjectRoute.
Caveats/Notes
Longer term, perspectives will be removed entirely from Unison Share as we just deal with projects and never the codebase in full.