This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Temporarily hide the _catalog doc #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unison Share will have a new front page that features a catalog which is derived from a Unison Doc. This page will mean that users will never see a tree view of the top of the Unison Share like they do now. While the Catalog page is being worked on, but not switched over to, we want to hide the _catalog doc from the top level codebase tree to avoid any confusion. This should be removed later when the Catalog page is in place.
pchiusano
approved these changes
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unison Share will have a new front page that features a catalog which is derived from a Unison Doc. This page will mean that users will never see a tree view of the top of the Unison Share like they do now.
While the Catalog page is being worked on, but not switched over to, we want to hide the _catalog doc from the top level codebase tree to avoid any confusion.
This will enable us to merge unisonweb/share#30 and to start exploring the catalog on a url that isn't linked to from anywhere.
Solution
Add a simple check to hide codebase tree entries named
_catalog.Caveats/Notes
_catalogregardless of where in the tree they are, but this is deemed ok since its temporary.