This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Fix Safari Finder render issue #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Safari (and perhaps other browsers?) `transparent` when used in gradients are rendered with a strange dark fade instead of actually being transparent. Using rgba with a 0 alpha fixes this. Specifically this was noticed in the Finder (there's a truncation fade effect on the right hand side), but could be else where in the app as well. The fix was to add a new css variable: `--color-transparent` that evaluates to `rgba(255, 255, 255, 0)` and use that in place of `transparent` everywhere.
pchiusano
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In Safari (and perhaps other browsers?)
transparentwhen used ingradients are rendered with a strange dark fade instead of actually
being transparent. Using rgba with a 0 alpha fixes this. Specifically
this was noticed in the Finder (there's a truncation fade effect on the
right hand side), but could be else where in the app as well.
The fix was to add a new css variable:
--color-transparentthatevaluates to
rgba(255, 255, 255, 0)and use that in place oftransparenteverywhere.Before
After
Fixes #233