This repository was archived by the owner on Jul 19, 2022. It is now read-only.
WorkspaceItem: Add hash, namespace menu items #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the small strip next to the name of an open definition to be more of a list of menu items with hover treatments for things like hash and other names.
hojberg
force-pushed
the
add-workspace-item-menu-items
branch
from
f47bd51 to
2b8436f
Compare
pchiusano
approved these changes
Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update the small strip next to the name of an open definition to be more
of a list of menu items with hover treatments for things like hash and
other names.
Interesting/controversial decisions
This changes the behavior of showing the namespace as "fqn minus suffix" and instead always shows "fqn minus unqualified name" such that
base.Listas a suffix name would showbasein the namespace menu item. This is done because this menu item is eventually going to have a flyout menu to change the UI perspective and to focus a Finder search within a namespace.