feat: add eslint; more lint more better #4618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Hegnes <eric@hegnes.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
App 2 🤌✨ Deployment complete! Take a peek over at https://6a84f9ae.app2-9yo.pages.dev |
ehegnes
commented
May 26, 2025
Comment on lines
+7
to
+15
| eslint-lint: &eslint-lint | ||
| lint-command: 'eslint_d --format unix --stdin --stdin-filename "${INPUT}"' | ||
| lint-stdin: true | ||
| lint-ignore-exit-code: true | ||
| lint-formats: | ||
| - '%f:%l:%c: %m [%trror]' | ||
| - '%f:%l:%c: %m [%tarning]' | ||
| root-markers: | ||
| - 'eslint.config.ts' |
There was a problem hiding this comment.
What efm-langserver runs for a given input.
Comment on lines
-76
to
+87
| auto-format = true | ||
| formatter = { command = "treefmt", args = ["--stdin", ".js"] } | ||
| language-servers = [{ name = "typescript-language-server", except-features = ["format"] }] | ||
| name = "javascript" | ||
| auto-format = true | ||
| formatter = { command = "treefmt", args = ["--stdin", ".js"] } | ||
| language-servers = [ | ||
| { name = "typescript-language-server", except-features = ["format"] }, | ||
| { name = "efm-langserver", except-features = ["format"] }, | ||
| ] | ||
| name = "javascript" |
There was a problem hiding this comment.
Additive diagnostics without format.
Comment on lines
+1
to
+15
| import { includeIgnoreFile } from "@eslint/compat" | ||
| import * as U from "@unionlabs/eslint-config" | ||
| import type { Linter } from "eslint" | ||
| import svelteConfig from "./svelte.config.js" | ||
|
|
||
| const gitignore = includeIgnoreFile( | ||
| new URL(import.meta.resolve("./.gitignore")).pathname, | ||
| ) | ||
|
|
||
| const config: Linter.Config[] = [ | ||
| gitignore, | ||
| ...U.configs.svelte(svelteConfig), | ||
| ] | ||
|
|
||
| export default config |
There was a problem hiding this comment.
Much simpler and more consistent.
| @@ -0,0 +1,38 @@ | |||
| { | |||
| "name": "@unionlabs/eslint-config", | |||
There was a problem hiding this comment.
New workspace project to contain ESLint config for various projects. Currently supports JS, TS, and Svelte.
Changes to this project update in real-time for sibling workspace projects given that we are exporting TS and using workspace linking.
Comment on lines
+510
to
+511
| efm-langserver | ||
| eslint_d |
Signed-off-by: Eric Hegnes <eric@hegnes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.