Skip to content

refactor(zk_verifier): reuse HashToField from cometbls/crypto/bn254 #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Himess
Copy link
Contributor

@Himess Himess commented May 18, 2025

This PR removes the locally defined HashToField function in zk_verifier.go and instead reuses the implementation provided in the cometbls repository under:

The function was already defined and exported in the bn254 module, so duplicating it locally was unnecessary.

Changes:

  • Removed the local HashToField function from zk_verifier.go
  • Replaced it with comet.HashToField from github.com/unionlabs/cometbls/crypto/bn254
  • Verified that the behavior and logic match the original

Closes #2804

Copy link

vercel bot commented May 18, 2025

@Himess is attempting to deploy a commit to the unionbuild Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: Himess <95512809+Himess@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse cometbls for hashToField function
1 participant