Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1760 Bad type hint for argument unique for DataFrameSchema #1817

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Jarek-Rolski
Copy link
Contributor

Problem description:

  • init sets _unique attribute
  • class DataFrameSchema defines unique property, getter returns _unique attribute, setter modifies string value into list of strings and saves to _unique attribute
  • other package functions use unique property

Because of above, unique property setter is never invoked. Thus string value is never turned into list of strings as I believe was intended.

I added code turning string into list of string to __init__ function. I've also found same issue in dataframe and pyspark modules.

Signed-off-by: Jarek-Rolski <jaroslaw.rolski@yahoo.com>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (812b2a8) to head (c0e68d9).
Report is 150 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
- Coverage   94.28%   93.23%   -1.05%     
==========================================
  Files          91      120      +29     
  Lines        7013     9155    +2142     
==========================================
+ Hits         6612     8536    +1924     
- Misses        401      619     +218     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy
Copy link
Collaborator

thanks @Jarek-Rolski, and congrats on your first PR to pandera! 🚀

@cosmicBboy cosmicBboy merged commit 0207fba into unionai-oss:main Sep 25, 2024
145 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants