Bugfix/1760 Bad type hint for argument unique for DataFrameSchema #1817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description:
_unique
attributeDataFrameSchema
definesunique
property, getter returns_unique
attribute, setter modifies string value into list of strings and saves to_unique
attributeunique
propertyBecause of above,
unique
property setter is never invoked. Thus string value is never turned into list of strings as I believe was intended.I added code turning string into list of string to
__init__
function. I've also found same issue in dataframe and pyspark modules.