-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not test Ibis below py3.9, add DuckDB for tests #1773
Conversation
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
bcd6925
to
e2a691d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ibis-dev #1773 +/- ##
============================================
- Coverage 94.29% 92.84% -1.45%
============================================
Files 91 130 +39
Lines 7024 9403 +2379
============================================
+ Hits 6623 8730 +2107
- Misses 401 673 +272 ☔ View full report in Codecov by Sentry. |
|
74c46f1
to
ea391fc
Compare
@cosmicBboy I would prefer to drop 3.8 and 3.9 altogether; see https://discord.com/channels/897120336003334214/1237117799810469928/1268547405046087750 for a lot more details. edit: 3.8 and 3.9, not 3.9 and 3.10 |
bed3b4e
to
8bc5819
Compare
Failing now because need #1779; I can cherry-pick it in once merged to |
* Swap `types-pkg_resources` with `types-setuptools` Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Update the expected error message to name variable Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Fix expected outputs for pandas-stubs 2.2.2.240807 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Update CI configuration to filter right pandas ver Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
just merged #1779, thanks for the fix! |
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
8bc5819
to
89fd955
Compare
Thanks @cosmicBboy! I updated this PR, also merging the changes from |
Ibis follows NEP-29 much more aggressively than Pandera,
so not going to bother with anything older than Python 3.10but still trying to run with 3.10 (for now). Hopefully this will make some of the CI issues go away.See also: #1451 (comment)