Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin mypy from requirements, xfail on unstable tests #1338

Merged
merged 2 commits into from
Sep 14, 2023
Merged

unpin mypy from requirements, xfail on unstable tests #1338

merged 2 commits into from
Sep 14, 2023

Conversation

cosmicBboy
Copy link
Collaborator

@cosmicBboy cosmicBboy commented Sep 14, 2023

This PR unpins mypy and pandas-stubs requirements for the pandera[mypy] extra, but maintains the mypy==0.982 constraint since the pandera codebase itself needs to be update to support later versions of mypy

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +16.97% 🎉

Comparison is base (850dcf8) 76.94% compared to head (111e7b3) 93.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1338       +/-   ##
===========================================
+ Coverage   76.94%   93.92%   +16.97%     
===========================================
  Files          91       91               
  Lines        6676     6767       +91     
===========================================
+ Hits         5137     6356     +1219     
+ Misses       1539      411     -1128     

see 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy changed the title unpin mypy from requirements, only run mypy CI on py3.10+ unpin mypy from requirements, xfail on unstable tests Sep 14, 2023
@cosmicBboy cosmicBboy merged commit c240b1b into main Sep 14, 2023
61 checks passed
@cosmicBboy cosmicBboy deleted the mypy branch September 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant