Bugfix: Update drop invalid logic to handle multi-index dfs #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Baden Ashford <baden.ashford@gmail.com>
Signed-off-by: Baden Ashford <baden.ashford@gmail.com>
Signed-off-by: Baden Ashford <baden.ashford@gmail.com>
kykyi
commented
Aug 18, 2023
| @@ -2330,6 +2330,141 @@ class Config: | |||
| MySchema.validate(actual_obj, lazy=False) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
Chat GPT can be credited with the LOTR specifics 🧝 💍
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 90 90
Lines 6704 6709 +5
=======================================
+ Hits 6290 6295 +5
Misses 414 414
☔ View full report in Codecov by Sentry. |
|
thanks @kykyi ! 🚀 |
cosmicBboy
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug on multi-index dataframes as outlined in this bug report