Bugfix: Ensure defaults are correctly applied #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Baden Ashford <baden.ashford@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 65 65
Lines 5101 5106 +5
=======================================
+ Hits 4961 4966 +5
Misses 140 140
☔ View full report in Codecov by Sentry. |
cosmicBboy
approved these changes
Jun 28, 2023
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing: #1193
The default values is currently incorrectly applied to
check_obj, meaning that theNaNvalues are filled with the first columns default value 🥴This PR fixes this bug, ensuring that only the column/series/field's
NaNvalues are filled, not the entire dataframe!