Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hypothesis dependency optional (#1215) #1216

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Make hypothesis dependency optional (#1215) #1216

merged 1 commit into from
Jun 7, 2023

Conversation

leifwar
Copy link
Contributor

@leifwar leifwar commented Jun 6, 2023

Closes #1215

@cosmicBboy
Copy link
Collaborator

cosmicBboy commented Jun 6, 2023

Hi @leifwar , so the fix for this would be to make the mock SearchStrategy a generic type:

    T = typing.TypeVar("T)

    class SearchStrategy(typing.Generic[T]):  # type: ignore
        """placeholder type."""

Signed-off-by: Leif Warland <leif.warland@statnett.no>
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5792fb2) 97.23% compared to head (15a2730) 97.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          65       65           
  Lines        5066     5066           
=======================================
  Hits         4926     4926           
  Misses        140      140           
Impacted Files Coverage Δ
pandera/strategies/pandas_strategies.py 97.82% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, and congrats on your first PR to pandera @leifwar 🚀

@cosmicBboy cosmicBboy merged commit 19cc15d into unionai-oss:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of hypothesis type annotations forces downstream projects to install hypothesis
2 participants