Skip to content

Conversation

osdiab
Copy link
Contributor

@osdiab osdiab commented Jun 28, 2019

unist and vfile both already ship with types so removing the @types/* DefinitelyTyped definitions doesn't cause any issues. Ran yarn test and no complaints there.

@codecov-io

This comment has been minimized.

@ChristianMurphy
Copy link
Member

/cc @Rokt33r

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristianMurphy ChristianMurphy merged commit 2d41bd2 into unifiedjs:master Jun 29, 2019
wooorm pushed a commit to remarkjs/remark that referenced this pull request Jul 20, 2019
Related to unifiedjs/unified#53.
Related to unifiedjs/unified#54.
Related to unifiedjs/unified#56.
Related to unifiedjs/unified#57.
Related to unifiedjs/unified#58.
Related to unifiedjs/unified#59.
Related to unifiedjs/unified#60.
Related to unifiedjs/unified#61.
Related to unifiedjs/unified#62.
Related to unifiedjs/unified#63.
Related to unifiedjs/unified#64.
Related to #426.

Reviewed-by: Titus Wormer <tituswormer@gmail.com>
Reviewed-by: Junyoung Choi <fluke8259@gmail.com>
Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>

Co-authored-by: Junyoung Choi <fluke8259@gmail.com>
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
@wooorm wooorm changed the title use unist, vfile types instead of definitelytyped Use unist, vfile types instead of DefinitelyTyped Aug 10, 2019
@wooorm wooorm added ☂️ area/types This affects typings ⛵️ status/released 📦 area/deps This affects dependencies 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Aug 10, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies ☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

5 participants