Skip to content

fix: zero-extend tricore ld.bu(#2348) #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jvlegod wants to merge 1 commit into
base: dev
Choose a base branch
from
+40 −4
Open

fix: zero-extend tricore ld.bu(#2348) #2381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qemu/target/tricore/translate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5293,7 +5293,7 @@ static void decode_bo_addrmode_ld_post_pre_base(DisasContext *ctx)
tcg_gen_addi_tl(tcg_ctx, tcg_ctx->cpu_gpr_a[r2], tcg_ctx->cpu_gpr_a[r2], off10);
break;
case OPC2_32_BO_LD_BU_PREINC:
gen_ld_preincr(ctx, tcg_ctx->cpu_gpr_d[r1], tcg_ctx->cpu_gpr_a[r2], off10, MO_SB);
gen_ld_preincr(ctx, tcg_ctx->cpu_gpr_d[r1], tcg_ctx->cpu_gpr_a[r2], off10, MO_UB);
break;
case OPC2_32_BO_LD_D_SHORTOFF:
CHECK_REG_PAIR(r1);
Expand Down
42 changes: 39 additions & 3 deletions tests/unit/test_tricore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,42 @@
#include "unicorn_test.h"

const uint64_t code_start = 0x1000;
const uint64_t code_len = 0x4000;
const uint64_t code_start = 0x10000;
const uint64_t code_len = 0x10000;

TEST_LIST = {{NULL, NULL}};
static void uc_common_setup(uc_engine **uc, uc_arch arch, uc_mode mode,
const char *code, uint64_t size)
{
OK(uc_open(arch, mode, uc));
OK(uc_mem_map(*uc, code_start, code_len, UC_PROT_ALL));
OK(uc_mem_write(*uc, code_start, code, size));
}

static void test_tricore_ld_bu_preinc(void)
{
uc_engine *uc;
char code[] = "\x09\x2f\x41\x04"; // ld.bu d15, [+a2]0x1
const uint64_t data_addr = 0x20000;
uint32_t d15 = 0;
uint32_t a2 = data_addr;
uint8_t data = 0xbc;

uc_common_setup(&uc, UC_ARCH_TRICORE, UC_MODE_LITTLE_ENDIAN, code,
sizeof(code) - 1);
OK(uc_mem_map(uc, data_addr, 0x10000, UC_PROT_ALL));
OK(uc_mem_write(uc, data_addr + 1, &data, sizeof(data)));
OK(uc_reg_write(uc, UC_TRICORE_REG_A2, &a2));

OK(uc_emu_start(uc, code_start, code_start + sizeof(code) - 1, 0, 1));

OK(uc_reg_read(uc, UC_TRICORE_REG_D15, &d15));
OK(uc_reg_read(uc, UC_TRICORE_REG_A2, &a2));

TEST_CHECK(a2 == data_addr + 1);
TEST_CHECK(d15 == 0x000000bc);

OK(uc_close(uc));
}

TEST_LIST = {
{"test_tricore_ld_bu_preinc", test_tricore_ld_bu_preinc},
{NULL, NULL}};
Loading