Skip to content

virtual mmu base tlb permissions based on Region if availible #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilippTakacs wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

virtual mmu base tlb permissions based on Region if availible #2273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a84e91d
virtual mmu base tlb permissions based on Region if availible
PhilippTakacs Dec 15, 2025
9a95cbf
fixup! virtual mmu base tlb permissions based on Region if availible
PhilippTakacs Dec 15, 2025
0bc3fbf
fixup! fixup! virtual mmu base tlb permissions based on Region if ava…
PhilippTakacs Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions qemu/softmmu/unicorn_vtlb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ bool unicorn_fill_tlb(CPUState *cs, vaddr address, int size,
bool handled = false;
bool ret = false;
struct uc_struct *uc = cs->uc;
MemoryRegion *mr;
uc_tlb_entry e;
struct hook *hook;
HOOK_FOREACH_VAR_DECLARE;
Expand All @@ -77,20 +78,26 @@ bool unicorn_fill_tlb(CPUState *cs, vaddr address, int size,

if (!handled) {
e.paddr = address & TARGET_PAGE_MASK;
mr = uc->memory_mapping(uc, e.paddr);
if (mr) {
e.perms = mr->perms;
} else {
e.perms = UC_PROT_NONE;
}
switch (rw) {
case MMU_DATA_LOAD:
e.perms = UC_PROT_READ;
e.perms |= UC_PROT_READ;
break;
case MMU_DATA_STORE:
e.perms = UC_PROT_WRITE;
e.perms |= UC_PROT_WRITE;
break;
case MMU_INST_FETCH:
e.perms = UC_PROT_EXEC;
e.perms |= UC_PROT_EXEC;
break;
default:
e.perms = 0;
break;
}

}

switch (rw) {
Expand Down
28 changes: 27 additions & 1 deletion tests/unit/test_mips.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,31 @@ static void test_mips_simple_coredump_2137(void)
OK(uc_close(uc));
}

static void test_mips_EXCP_RI_virtual(void)
{
uc_engine *uc;

/*
* b 0x1008
* lb $v0, ($s8)
* b 0x1000
* addiu $s0, $s0, 1
*/
const char code[] = "\x01\x00\x00\x10\x00\x00\xc2\x83\xFD\xFF\x00\x10\x01\x00\x10\x26";
uint64_t base = 0x1000;

OK(uc_open(UC_ARCH_MIPS, UC_MODE_MIPS32, &uc));
OK(uc_mem_map(uc, base, 0x1000, UC_PROT_ALL));
OK(uc_mem_write(uc, base, code, sizeof(code) - 1));

OK(uc_ctl_tlb_mode(uc, UC_TLB_VIRTUAL));

OK(uc_reg_write(uc, UC_MIPS_REG_S8, &base));
OK(uc_emu_start(uc, base, base + sizeof(code) - 1, 0, 20));

OK(uc_close(uc));
}

TEST_LIST = {
{"test_mips_stop_at_branch", test_mips_stop_at_branch},
{"test_mips_stop_at_delay_slot", test_mips_stop_at_delay_slot},
Expand All @@ -234,4 +259,5 @@ TEST_LIST = {
test_mips_stop_delay_slot_from_qiling},
{"test_mips_simple_coredump_2134", test_mips_simple_coredump_2134},
{"test_mips_simple_coredump_2137", test_mips_simple_coredump_2137},
{NULL, NULL}};
{"test_mips_EXCP_RI_virtual", test_mips_EXCP_RI_virtual},
{NULL, NULL}};
Loading