Add Cascade Prediction Feature #6
Open
rahulvalyu wants to merge 19 commits intounicodeveloper:mainfrom
Open
Conversation
- Add OAuth proxy route for authenticated API calls - Update valyu.ts to support OAuth tokens with proxy fallback - Add shared usage limits (5 event loads, 2 country clicks) - Show sign-in modal when limits reached in valyu mode - Self-hosted mode unchanged - uses API key with no limits - Add loading time estimate to country conflicts modal - Fix dialog header centering - Update auth panel with globe icon Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
event classification
tuyyui
reviewed
Jan 27, 2026
Comment on lines
+168
to
+169
| console.error("Cascade analysis error:", error); | ||
| const errorMessage = error instanceof Error ? error.message : "Unknown error"; |
There was a problem hiding this comment.
Probably switch these around and log the errorMessage instead? I guess a mixture of both is fine.
tuyyui
reviewed
Jan 27, 2026
Comment on lines
129
to
135
| const requiresReauth = searchResultsArrays.some((r) => r.requiresReauth); | ||
| if (requiresReauth) { | ||
| return NextResponse.json( | ||
| { error: "auth_error", message: "Session expired. Please sign in again.", requiresReauth: true }, | ||
| { status: 401 } | ||
| ); | ||
| } |
There was a problem hiding this comment.
Since requiresReauth isn't being used elsewhere you can place the .some statement inside of the if statement.
tuyyui
reviewed
Jan 27, 2026
There was a problem hiding this comment.
Why not return the response.status for a more preciese error code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary
Changes
How to Test