Skip to content

Conversation

@gregtatum
Copy link
Member

In issue #681, Zibi audited our docs. Skeleton must be exposed for the Data Provider machinery, but it's not really a public API that our users should directly use (unless we decide otherwise). I could make the skeleton mod pub(mod), and only re-export the Skeleton and SkeletonError types, but I figured it would be better to not even expose them to user-facing documentation.

This would be the same way that the pattern module is working.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 77d84fda59d08c591bc1736ed5e36a60f5d1e21e-PR-689

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 73.439%

Files with Coverage Reduction New Missed Lines %
experimental/provider_ppucd/src/parse_ppucd.rs 1 93.0%
Totals Coverage Status
Change from base Build e78289331a514adbce008364653dce2fed9ddced: -0.009%
Covered Lines: 8140
Relevant Lines: 11084

💛 - Coveralls

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like #[doc(hidden)]. It's a nice way to get around the problem of needing to export types that aren't intended for public use.

@zbraniecki zbraniecki merged commit 750dc07 into unicode-org:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants