Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve time zone docs #5710

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Improve time zone docs #5710

merged 5 commits into from
Oct 18, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Oct 18, 2024

Addresses feedback in #5707
Depends on #5708

Copy link

dpulls bot commented Oct 18, 2024

🎉 All dependencies have been resolved !

@sffc sffc marked this pull request as ready for review October 18, 2024 21:57
@sffc sffc requested a review from zbraniecki as a code owner October 18, 2024 21:57
@sffc sffc removed the request for review from zbraniecki October 18, 2024 21:57
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't address the CustomZonedDateTime comment which you have left unanswered on the other PR.

@sffc
Copy link
Member Author

sffc commented Oct 18, 2024

How's this?

@@ -1078,7 +1078,7 @@ impl_zone_marker!(
/// All shapes of time zones can be formatted with this style.
///
/// ```
/// use icu::calendar::{DateTime, Iso};
/// use icu::calendar::{Date, Time};
/// use icu::datetime::FixedCalendarDateTimeFormatter;
/// use icu::datetime::fieldset::NeoTimeZoneOffsetMarker;
/// use icu::datetime::neo_skeleton::NeoSkeletonLength;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZoneDateTime import can go

@sffc sffc merged commit a1823e4 into unicode-org:main Oct 18, 2024
28 checks passed
@sffc sffc deleted the tz-docs branch October 19, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants