-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve time zone docs #5710
Improve time zone docs #5710
Conversation
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't address the CustomZonedDateTime comment which you have left unanswered on the other PR.
How's this? |
@@ -1078,7 +1078,7 @@ impl_zone_marker!( | |||
/// All shapes of time zones can be formatted with this style. | |||
/// | |||
/// ``` | |||
/// use icu::calendar::{DateTime, Iso}; | |||
/// use icu::calendar::{Date, Time}; | |||
/// use icu::datetime::FixedCalendarDateTimeFormatter; | |||
/// use icu::datetime::fieldset::NeoTimeZoneOffsetMarker; | |||
/// use icu::datetime::neo_skeleton::NeoSkeletonLength; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZoneDateTime import can go
Addresses feedback in #5707
Depends on #5708