Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More FSet renames; GetField; rm NeverCalendar #5686

Merged
merged 3 commits into from
Oct 15, 2024
Merged

More FSet renames; GetField; rm NeverCalendar #5686

merged 3 commits into from
Oct 15, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Oct 15, 2024

Depends on #5676

Not sure if I like NeverCalendar or () better.

Manishearth
Manishearth previously approved these changes Oct 15, 2024
View reviewed changes
@dpulls dpulls
Copy link

dpulls bot commented Oct 15, 2024

🎉 All dependencies have been resolved !

@sffc sffc requested a review from Manishearth October 15, 2024 21:12
Manishearth
Manishearth approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either but I think () works here so it's fine

@sffc sffc merged commit eaacd10 into unicode-org:main Oct 15, 2024
28 checks passed
@sffc sffc deleted the more-fset branch October 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sffc @Manishearth