Use Option<T> over FFI #5485
Merged
Use Option<T> over FFI #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
ffi-option
branch
from
b3a4851
to
95896d1
Compare
Manishearth
force-pushed
the
ffi-option
branch
3 times, most recently
from
9daa508
to
faa1dd9
Compare
|
Ready for review. I think this is the last large part of FFI future-proofing. |
Manishearth
force-pushed
the
ffi-option
branch
from
faa1dd9
to
29be928
Compare
| @@ -77,7 +70,7 @@ pub mod ffi { | |||
| secondary_group_size: u8, | |||
| min_group_size: u8, | |||
| digits: &[DiplomatChar], | |||
| grouping_strategy: FixedDecimalGroupingStrategy, | |||
| grouping_strategy: Option<FixedDecimalGroupingStrategy>, | |||
There was a problem hiding this comment.
I think it's inconsistent to not have an options bag on some APIs, when the Rust API takes an options bag. Everywhere you call Options::default() in a constructor it should really take a bag.
There was a problem hiding this comment.
Yeah, perhaps we should tweak this
robertbastian
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.