Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace resolved components API with neo-based alternative #5465

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Aug 29, 2024

#1317

This uses the components API, which I'd like to deprecate/remove, but it doesn't really hurt to keep it around I guess? Would like if it could go into an ecma402-specific wrapper.

@sffc sffc marked this pull request as ready for review September 3, 2024 23:49
@sffc sffc requested review from Manishearth and removed request for nordzilla September 3, 2024 23:49
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sffc sffc changed the title Add impl and test showing how to get the resolved components Replace resolved components API with neo-based alternative Sep 4, 2024
sffc added a commit that referenced this pull request Sep 4, 2024
Split from #5465

Happy to close this and keep the change in the context of #5465
@sffc sffc merged commit 4636092 into unicode-org:main Sep 4, 2024
28 checks passed
@sffc sffc deleted the resolved-components-neo branch September 4, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants