Add u-hc hour cycle support to neo time formatter #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
robertbastian,
Manishearth,
zbraniecki,
nordzilla and
a team
as code owners
components/datetime/src/raw/neo.rs
Outdated
| // First try to load with the explicit hour cycle. If there is no explicit hour cycle, | ||
| // or if loading the explicit hour cycle fails, then load with the default hour cycle. | ||
| let mut maybe_payload = None; | ||
| if let Some(hc) = locale.get_unicode_ext(&icu_locale_core::extensions::unicode::key!("hc")) |
There was a problem hiding this comment.
suggestion: resolve the hc at the top-level constructor, and pass it separately from DataLocale. This will make it easier to remove Unicode extensions from DataLocale and migrate the input DataLocale to preferences.
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
robertbastian
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1317
Getting really close to feature parity.