Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .wat instead of .wasm in tree #5282

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Use .wat instead of .wasm in tree #5282

merged 2 commits into from
Jul 24, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Jul 23, 2024

Fixes #5194

@sffc sffc requested a review from robertbastian July 23, 2024 21:52
@sffc sffc requested review from echeran and a team as code owners July 23, 2024 21:52
@sffc
Copy link
Member Author

sffc commented Jul 23, 2024

The nice thing about the .wat is that you can see what it imports and exports. In this case, we have no imports and the only exports are ICU4C symbols and the symbols we created:

  (table (;0;) 1 1 funcref)
  (memory (;0;) 2)
  (global (;0;) (mut i32) (i32.const 67088))
  (export "memory" (memory 0))
  (export "_initialize" (func 1))
  (export "ucptrie_close" (func 13))
  (export "umutablecptrie_open" (func 14))
  (export "umutablecptrie_close" (func 26))
  (export "umutablecptrie_set" (func 27))
  (export "umutablecptrie_buildImmutable" (func 33))
  (export "create_uerrorcode" (func 77))
  (export "read_uerrorcode" (func 78))
  (export "read_ucptrie_highStart" (func 79))
  (export "read_ucptrie_shifted12HighStart" (func 80))
  (export "read_ucptrie_index3NullOffset" (func 81))
  (export "read_ucptrie_dataNullOffset" (func 82))
  (export "read_ucptrie_nullValue" (func 83))
  (export "get_index_ptr" (func 84))
  (export "get_index_length" (func 85))
  (export "get_data_ptr" (func 86))
  (export "get_data_length" (func 87))
  (data (;0;) (i32.const 1024) "\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00"))

@sffc sffc removed request for a team and echeran July 23, 2024 22:00
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the linked issue this should be checked by CI, yes?

@Manishearth
Copy link
Member

Oh I see the plan. That works. Asserting that it is the same is going to be very brittle anyway.

@sffc sffc merged commit e0ed5ac into unicode-org:main Jul 24, 2024
28 checks passed
@sffc sffc deleted the wat branch July 24, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert correct generation of codepointtrie_builder/ucptrie_wrap.wasm in CI
3 participants