Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DurationFormatter: Duration Formatter Digital Implementation #5263

Merged
merged 9 commits into from
Jul 31, 2024

Conversation

kartva
Copy link
Member

@kartva kartva commented Jul 18, 2024

Blocked on merging #5208

@kartva kartva force-pushed the duration-formatter-digital-impl branch 3 times, most recently from 585c79b to 6cb98f9 Compare July 29, 2024 18:03
@kartva kartva requested review from sffc and younies July 29, 2024 18:04
@kartva kartva marked this pull request as ready for review July 29, 2024 18:25
@kartva kartva requested a review from a team as a code owner July 29, 2024 18:25
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good start!

components/experimental/src/duration/format.rs Outdated Show resolved Hide resolved
components/experimental/src/duration/format.rs Outdated Show resolved Hide resolved
components/experimental/src/duration/format.rs Outdated Show resolved Hide resolved
components/experimental/src/duration/format.rs Outdated Show resolved Hide resolved
components/experimental/src/duration/format.rs Outdated Show resolved Hide resolved
components/experimental/src/duration/format.rs Outdated Show resolved Hide resolved
@kartva kartva requested a review from sffc July 30, 2024 00:51
Copy link
Member

@younies younies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, send the piece of code for decimal.rs in a different PR and lets discuss this PR today

@younies younies self-requested a review July 30, 2024 09:21
Copy link
Member

@younies younies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CLI

sffc
sffc previously approved these changes Jul 30, 2024
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I agree it would be nice to pull the fixed_decimal change into its own PR that lands before this one

components/experimental/src/duration/format.rs Outdated Show resolved Hide resolved
@kartva
Copy link
Member Author

kartva commented Jul 31, 2024

Filed #5319 for fixed_decimal bug fix, and reverted the change in this PR.

@kartva kartva force-pushed the duration-formatter-digital-impl branch from 3225183 to 9d6cb8b Compare July 31, 2024 02:50
@kartva kartva requested review from sffc and younies July 31, 2024 03:37
Comment on lines +75 to +83
impl DurationSign {
pub(crate) fn as_fixed_decimal_sign(&self) -> fixed_decimal::Sign {
match self {
DurationSign::Positive => fixed_decimal::Sign::Positive,
DurationSign::Negative => fixed_decimal::Sign::Negative,
}
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a following PR:

Suggested change
impl DurationSign {
pub(crate) fn as_fixed_decimal_sign(&self) -> fixed_decimal::Sign {
match self {
DurationSign::Positive => fixed_decimal::Sign::Positive,
DurationSign::Negative => fixed_decimal::Sign::Negative,
}
}
}
impl As<fixed_decimal::Sign> for DurationSign {
fn as(&self) -> Sign {
match self {
DurationSign::Positive => fixed_decimal::Sign::Positive,
DurationSign::Negative => fixed_decimal::Sign::Negative,
}
}
}

@younies younies closed this Jul 31, 2024
@younies younies reopened this Jul 31, 2024
@sffc sffc merged commit f6237e9 into unicode-org:main Jul 31, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants