Implement DeduplicationStrategy::RetainBaseLanguages
#4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
sffc,
robertbastian and
Manishearth
as code owners
jedel1043
force-pushed
the
retain-base-langs
branch
from
046c293
to
1c71a0d
Compare
robertbastian
approved these changes
Apr 23, 2024
sffc
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
LGTM with the following notes:
- The output behavior looks correct but the code might need to be changed when the remainder of Implement Datagen API LocaleExpansionMode #4629 (comment) is implemented
- This PR doesn't change any defaults. I have gone back and forth on whether this should be the default. I think that's a discussion we should have again closer to 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #58. Closes it? I'm not sure because there are also discussions about a
can_loadmethod, but this is the bare minimum to support the use case.