Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the Dart FFI package for publish #4299

Closed
wants to merge 14 commits into from

Conversation

mosuem
Copy link

@mosuem mosuem commented Nov 15, 2023

Prepare the Dart bindings for publishings.

Do not submit until truongsinh/icu-flutter#3 is resolved.

@mosuem mosuem requested a review from a team as a code owner November 15, 2023 11:11
@mosuem mosuem requested a review from sffc as a code owner November 15, 2023 11:17
ffi/capi/dart/package/LICENSE Outdated Show resolved Hide resolved
ffi/capi/dart/package/pubspec.yaml Outdated Show resolved Hide resolved
ffi/capi/dart/package/pubspec.yaml Outdated Show resolved Hide resolved
tools/make/tidy.toml Outdated Show resolved Hide resolved
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the Dart package? It looks fine but I trust you two on the details :)

@sffc sffc changed the title Prepare for publish Prepare the Dart FFI package for publish Nov 15, 2023
ffi/capi/dart/package/README.md Show resolved Hide resolved
ffi/capi/dart/package/README.md Outdated Show resolved Hide resolved
mosuem and others added 2 commits November 16, 2023 13:48
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
robertbastian
robertbastian previously approved these changes Nov 16, 2023
@robertbastian
Copy link
Member

I guess we can merge because it doesn't auto-publish?

@mosuem
Copy link
Author

mosuem commented Nov 17, 2023

@robertbastian I would hold off until the name issue is resolved.

@robertbastian
Copy link
Member

Well the name is not changing with this PR.

@mosuem
Copy link
Author

mosuem commented Nov 17, 2023

If the current owner of package:icu wants to keep it, we will have to change the name. I would prefer to do this in this PR, so that the package is indeed prepared for publishing :)

@JulianSchmidtZollsoft
Copy link

Hi :)
@mosuem do you have a rough estimate for when this dart package will be published? We want to use it for locale comparing Strings.

Thanks in advance.

@robertbastian
Copy link
Member

We're at the moment undecided whether/how to release this package. Our goal is to release a new intl package, which uses ICU4X under the hood, this might or might not use this package. You can find the draft at https://github.com/dart-lang/i18n/tree/main/pkgs/intl, and there's a work-in-progress pull request to use ICU4X.

Open issues at the moment are binary size and how to do locale selection.

@robertbastian
Copy link
Member

This is mostly obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants