-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move casemap out of experimental; final graduation cleanups #3803
Conversation
One question is: |
We should remove the feature, clients will need to update their code for API changes anyway. |
810fac4
to
3a55cc2
Compare
558d521
to
02048c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought both datagen and the metacrate had component-specific features ? |
@sffc can we please merge this without finishing the checklist? That checklist was not complete before you added more entries to it, I'm aware there's more work to be done there. I don't think moving this component must be the last step, I'm happy to remove the "fixes ..." from the PR body but there's basically no chance 1.3 is happening without stabilizing this and we should land this somewhat churny PR at some point.
nope, only for experimental this is the first time in the datagen features world we are graduating from experimental that said, it occurs to me these features did not exist pre-1.3 anyway so this change is something that can be made without breaking anyone; next release we will need to figure out what to do about experimental components that graduate |
02048c1
to
6f94526
Compare
6f94526
to
9eb712d
Compare
I had some time and I've gone ahead and resolved most of the checklist items. I'd prefer to get this merged to avoid conflicts rather than blocking this on incomplete checklists, though, so if there are things still unhandled I would love to know but would prefer to not block landing on it. |
ok, it's not implemented yet: #3165 I think we've mentioned whether we want to do this for the metacrate but I think the consensus has been that you should use the specific crates instead of the metacrate in that situation. |
I'll defer to Robert on this; the PR is large with many commits and I don't have time to give it a thorough review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer to Rob on this PR. If Rob doesn't review then add me back in a few days.
autosubmit=true |
There are lots of files showing as additions, I think you have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some changes so autosubmit turned off
Part of #3234
There is one leftover issue to be decided there, #3801 , btu I'm comfortable doing the moving right now and we can fix that before release if needed.