Split unfold functionality into separate type #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
a team,
sffc and
robertbastian
as code owners
31 tasks
Manishearth
force-pushed
the
unfold-separate
branch
from
a732f67
to
44c10dd
Compare
Manishearth
force-pushed
the
unfold-separate
branch
from
44c10dd
to
8c08cec
Compare
sffc
reviewed
Aug 1, 2023
Comment on lines
+152
to
+153
| /// In other words, this adds all strings/characters that this casemaps to, as | ||
| /// well as all characters that may casemap to this one. |
There was a problem hiding this comment.
Question: Does this include all case mapping operations, or only case folding?
sffc
reviewed
Aug 1, 2023
experimental/casemap/src/closer.rs
Outdated
| self.cm.as_ref().add_case_closure(c, set); | ||
| } | ||
|
|
||
| /// Finds all characters and strings which may casemap to `s` and adds them to the set. |
There was a problem hiding this comment.
Question: does it also include all characters and strings which s casemaps to? Or only those which casemap to s?
experimental/casemap/src/closer.rs
Outdated
Comment on lines
194
to
198
| /// let cm = CaseMapCloser::new(); | ||
| /// let mut builder = CodePointInversionListBuilder::new(); | ||
| /// let found = cm.add_string_case_closure("ffi", &mut builder); | ||
| /// assert!(found); | ||
| /// let set = builder.build(); |
There was a problem hiding this comment.
Question: what happens if my string is ffiss? Do I get ffiss, ffiß, and ffiß all added to my set?
There was a problem hiding this comment.
nothing, it's only for the atomic casemappings.
I don't think there's good terminology around this unfortunately.
sffc
reviewed
Aug 1, 2023
sffc
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3234
(the first commit is a related minor change that I'm sneaking in)
Some things I'm not sure about:
&CaseMapperas an argumentWhatever design we end up with here will probably be exactly what I do for titlecase as well!