Less ZeroMap mutation in datagen #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Feb 9, 2023
Manishearth
reviewed
Feb 9, 2023
utils/zerovec/src/varzerovec/vec.rs
Outdated
| @@ -405,6 +405,18 @@ impl<'a, T: VarULE + ?Sized, F: VarZeroVecFormat> VarZeroVec<'a, T, F> { | |||
| } | |||
| } | |||
|
|
|||
| impl<A, T, F> From<Vec<A>> for VarZeroVec<'static, T, F> | |||
There was a problem hiding this comment.
not sure if we want an impliclty discarding conversion but i guess it's fine since From is known to be moving
There was a problem hiding this comment.
+1; prefer to not have the implicit moving conversion; where is it used? Seems better to change the call sites from myvec.into() to (&myvec).into() which is more explicit
There was a problem hiding this comment.
I mean, it's converting a Vec<T> into a VarZeroVec<T>, so no elements are discarded. Just because we don't move out of the Vec doesn't mean we cannot offer this API for ergonomics as well. But reverted.
sffc
previously approved these changes
Feb 9, 2023
Manishearth
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct all
ZeroMaps usingFromIteratorandBTreeMaps. This reduces the issue in #2826 toZeroMap'sFromIterator.