Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize PluralRules benchmarks #295

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Reorganize PluralRules benchmarks #295

merged 1 commit into from
Oct 5, 2020

Conversation

zbraniecki
Copy link
Member

Fixes #291

This is the implementation that keeps cargo bench do the simple thing and the rest is behind feature bench.

@zbraniecki zbraniecki requested a review from sffc as a code owner October 3, 2020 07:57
This was referenced Oct 3, 2020
Closed
Closed
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@coveralls
Copy link

Pull Request Test Coverage Report for Build a3b78cc2024b843821ee1c109be9310bd56ca74b-PR-295

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.008%) to 78.169%
Files with Coverage Reduction New Missed Lines %
components/pluralrules/src/error.rs 3 33.33%
components/pluralrules/src/data.rs 6 82.22%
components/pluralrules/src/operands.rs 7 83.54%
Totals Coverage Status
Change from base Build d3a6cd1651e9720fbd883cfa44d78906586213ad: 1.008%
Covered Lines: 2886
Relevant Lines: 3692
💛 - Coveralls

@filmil filmil self-requested a review October 5, 2020 19:17
@filmil
Copy link
Contributor

filmil commented Oct 5, 2020

Reviewing per request from @zbraniecki on slack.

filmil
filmil approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@filmil filmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very glad you decided to go with test naming for this purpose.

@zbraniecki zbraniecki merged commit 554b3b5 into unicode-org:master Oct 5, 2020
@zbraniecki zbraniecki deleted the pr-bench-sample branch October 19, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmil filmil filmil approved these changes

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Micro-benchmark layout
4 participants
@zbraniecki @coveralls @filmil @sffc