Using the cached-path crate for downloading and unzipping #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth and
a team
as code owners
robertbastian
commented
Mar 28, 2022
Comment on lines
+11
to
+12
| //! - [`CldrPathsLocal`] which points directly to each local CLDR file, and | ||
| //! - [`CldrPathsAllInOne`] which points to a local CLDR tree. |
There was a problem hiding this comment.
Do we need both of these going forward? CldrPathsLocal is unused and I can't think of a scenario where a client has CLDR data but it's not in the CLDR tree.
There was a problem hiding this comment.
If getting rid of CldrPathsLocal makes your life easier, you can get rid of it.
There was a problem hiding this comment.
It doesn't make it harder right now, I was just wondering what the idea behind it was.
There was a problem hiding this comment.
Versions of CLDR prior to 38 or 39 had separate repos and zip files for each tree, but then they merged them into one big tree. I kept the code for the old layout for the time being, but it can probably be removed now.
sffc
requested changes
Mar 29, 2022
sffc
approved these changes
Mar 29, 2022
Manishearth
approved these changes
Mar 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
Fixes #1739
Fixes #718
This removes custom CLDR download code, and also adds downloading capabilities for uprops
(however, that doesn't currently work asrelease-70-1is missing a file, andrelease-71-rcis missing all uprops data).