Fixing Option borrows (follow-up #1550) #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
gregtatum,
nordzilla,
zbraniecki and
a team
as code owners
robertbastian
requested review from
Manishearth and
sffc
and removed request for
zbraniecki,
gregtatum and
nordzilla
Manishearth
previously approved these changes
Jan 28, 2022
| feature = "provider_serde", | ||
| serde(borrow, with = "serde_with::As::<[serde_with::BorrowCow; 12]>") | ||
| )] | ||
| pub [Cow<'data, str>; 12], |
There was a problem hiding this comment.
question: is this necessary for [Cow; N] as well?
Manishearth
reviewed
Jan 28, 2022
| } | ||
| ); | ||
|
|
||
| #[cfg(all(test, feature = "provider_serde"))] | ||
| mod test { |
There was a problem hiding this comment.
thought: a cool test to perform (not in this PR) would be to use rust's custom per-collection allocator support to write a wrapping allocator that keeps track of memory allocated, and then construct a postcard based fs/static data provider and deserialize absolutely everything, printing out how much heap memory each component takes.
|
I'll need to come back to |
Manishearth
requested changes
Jan 28, 2022
Merged
Manishearth
previously approved these changes
Jan 31, 2022
sffc
previously approved these changes
Jan 31, 2022
Comment on lines
+11
to
+12
| // Cows fail to borrow in some situations (array, option), but structs of Cows don't. | ||
| pub struct CowWrap<'data>(#[serde(borrow)] Cow<'data, str>); |
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
approved these changes
Jan 31, 2022
Manishearth
approved these changes
Jan 31, 2022
Merged
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.