Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate SkeletonPatterns into its own key #1139

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

zbraniecki
Copy link
Member

Part of #257 which will make #519 easier.

It also does this:
Screenshot from 2021-10-01 14-57-58

@zbraniecki zbraniecki requested review from nordzilla and a team as code owners October 1, 2021 21:58
@zbraniecki zbraniecki removed request for a team and nordzilla October 1, 2021 21:59
@zbraniecki
Copy link
Member Author

There are no functional changes here. I moved provider::helpers to be provider::date_time since that's what it is really and introduced a temporary structure that lazily loads patterns/skeletons as needed. I think this architecture will pay off as we continue splitting data.

The rest is basically splitting patterns in multiple places into patterns and skeletons.

@zbraniecki zbraniecki removed the request for review from sffc October 4, 2021 18:44
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest pieces of feedback are on:

  • The naming of the "pattern" data payload being confusing, as it is not using the word "lengths".
  • Under documentation of the PatternSelector machinery. It was hard to read and understand the code, and it would be helpful to have that in place. Without documentation, I feel that these make understanding and maintaining the code worse for future contributors.

If you don't want to make the changes here, please file follow-ups.

components/datetime/src/provider/date_time.rs Show resolved Hide resolved
components/datetime/src/provider/date_time.rs Show resolved Hide resolved
components/datetime/src/provider/date_time.rs Show resolved Hide resolved
components/datetime/src/provider/date_time.rs Show resolved Hide resolved
components/datetime/src/skeleton.rs Show resolved Hide resolved
components/datetime/src/provider/mod.rs Show resolved Hide resolved
components/datetime/src/provider/date_time.rs Show resolved Hide resolved
components/datetime/src/provider/date_time.rs Show resolved Hide resolved
@zbraniecki zbraniecki merged commit 807116b into unicode-org:main Oct 4, 2021
@zbraniecki
Copy link
Member Author

I accidentally merged it without follow up cleanups:

Apologies everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants