-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate SkeletonPatterns into its own key #1139
Conversation
There are no functional changes here. I moved The rest is basically splitting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My biggest pieces of feedback are on:
- The naming of the "pattern" data payload being confusing, as it is not using the word "lengths".
- Under documentation of the PatternSelector machinery. It was hard to read and understand the code, and it would be helpful to have that in place. Without documentation, I feel that these make understanding and maintaining the code worse for future contributors.
If you don't want to make the changes here, please file follow-ups.
Part of #257 which will make #519 easier.
It also does this: