Skip to content

Commit

Permalink
Rename some FFI constructors (#5262)
Browse files Browse the repository at this point in the history
Renames
* `create_from_*` -> `from_*`, e.g. `create_from_string` ->
`from_string`
* `create_*` -> `*` where the constructor doesn't take arguments, e.g.
`create_und`, -> `und`

These names were already used as named constructors, so this basically
aligns C and C++ with that.
  • Loading branch information
robertbastian authored Jul 18, 2024
1 parent 3e30939 commit f7bc6ad
Show file tree
Hide file tree
Showing 132 changed files with 606 additions and 616 deletions.
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,10 @@ icu_benchmark_macros = { path = "tools/benchmark/macros" }

# The version here can either be a `version = ".."` spec or `git = "https://github.com/rust-diplomat/diplomat", rev = ".."`
# Diplomat must be published preceding a new ICU4X release but may use git versions in between
diplomat = { git = "https://github.com/rust-diplomat/diplomat", rev = "3b875c676f60a892eeb818c6a0f6f10086c69a24" }
diplomat-runtime = { git = "https://github.com/rust-diplomat/diplomat", rev = "3b875c676f60a892eeb818c6a0f6f10086c69a24" }
diplomat_core = { git = "https://github.com/rust-diplomat/diplomat", rev = "3b875c676f60a892eeb818c6a0f6f10086c69a24" }
diplomat-tool = { git = "https://github.com/rust-diplomat/diplomat", rev = "3b875c676f60a892eeb818c6a0f6f10086c69a24" }
diplomat = { git = "https://github.com/rust-diplomat/diplomat", rev = "dee60cf0463e082b89931854ed3322ce049cd31c" }
diplomat-runtime = { git = "https://github.com/rust-diplomat/diplomat", rev = "dee60cf0463e082b89931854ed3322ce049cd31c" }
diplomat_core = { git = "https://github.com/rust-diplomat/diplomat", rev = "dee60cf0463e082b89931854ed3322ce049cd31c" }
diplomat-tool = { git = "https://github.com/rust-diplomat/diplomat", rev = "dee60cf0463e082b89931854ed3322ce049cd31c" }

# EXTERNAL DEPENDENCIES
#
Expand Down
2 changes: 1 addition & 1 deletion ffi/capi/bindings/c/Collator.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions ffi/capi/bindings/c/CustomTimeZone.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions ffi/capi/bindings/c/DataProvider.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ffi/capi/bindings/c/Date.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions ffi/capi/bindings/c/DateTime.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 14 additions & 14 deletions ffi/capi/bindings/c/FixedDecimal.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ffi/capi/bindings/c/IsoDate.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ffi/capi/bindings/c/IsoDateTime.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ffi/capi/bindings/c/Locale.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ffi/capi/bindings/c/LocaleDisplayNamesFormatter.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ffi/capi/bindings/c/LocaleFallbacker.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ffi/capi/bindings/c/PluralOperands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ffi/capi/bindings/c/Time.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ffi/capi/bindings/c/TitlecaseOptionsV1.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ffi/capi/bindings/c/WeekCalculator.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f7bc6ad

Please sign in to comment.