Add NeoOptions with trait integration (#5248)

unicode-org · Jul 19, 2024 · 0704266 · 0704266
1 parent 6f84168
commit 0704266
Show file tree

Hide file tree

Showing 9 changed files with 233 additions and 110 deletions.
diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs
@@ -130,7 +130,7 @@ fn datetime_benches(c: &mut Criterion) {
                             TypedNeoFormatter::<Gregorian, _>::try_new_with_components(
                                 &locale.into(),
                                 neo_components,
-                                length,
+                                length.into(),
                             )
                             .expect("Failed to create TypedNeoFormatter.")
                         };

diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs
@@ -1067,8 +1067,9 @@ mod tests {
         use icu_calendar::Date;
 
         let locale = "en-u-ca-japanese".parse().unwrap();
-        let dtf = NeoFormatter::<NeoAutoDateMarker>::try_new(&locale, NeoSkeletonLength::Medium)
-            .expect("DateTimeFormat construction succeeds");
+        let dtf =
+            NeoFormatter::<NeoAutoDateMarker>::try_new(&locale, NeoSkeletonLength::Medium.into())
+                .expect("DateTimeFormat construction succeeds");
 
         let date = Date::try_new_gregorian_date(1800, 9, 1).expect("Failed to construct Date.");
         let date = date