Skip to content

Update names of files for "lang_names" to be consistent across phases of testing #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
30b0a18
Adding ICU4C running collation tests - first try
sven-oly Dec 5, 2023
3663d79
Cache ICU4C binaries in GH and locally, only if they don't exist
echeran Dec 6, 2023
8f1a829
Install JSON-C dependency if not installed at beginning of CI or e2e …
echeran Dec 6, 2023
4277048
Fix bash if condition syntax
echeran Dec 6, 2023
3e7a734
Merge branch 'main' of github.com:sven-oly/conformance
sven-oly Jan 4, 2024
8eca805
Merge branch 'main' into main
sven-oly Jan 4, 2024
7091b62
Merge branch 'main' of github.com:unicode-org/conformance
sven-oly Jan 4, 2024
350165f
Merge branch 'main' of github.com:unicode-org/conformance
sven-oly Jan 9, 2024
3c1068a
Merge branch 'main' of github.com:unicode-org/conformance
sven-oly Jan 11, 2024
8ca0ed9
Merge branch 'main' of github.com:unicode-org/conformance
sven-oly Jan 17, 2024
0af99f4
Merge branch 'main' of github.com:unicode-org/conformance
sven-oly Jan 19, 2024
67ce396
Merge branch 'main' of github.com:unicode-org/conformance
sven-oly Jan 19, 2024
943accd
Making compare report files
sven-oly Jan 20, 2024
d3b4fe2
Compare UI prototype
sven-oly Jan 23, 2024
9709f35
Merge branch 'main' of github.com:unicode-org/conformance into compar…
sven-oly Jan 24, 2024
72041f9
Compare: Moving toward comparison with hash_id
sven-oly Jan 25, 2024
68c0c97
Merge remote-tracking branch 'upstream/main' into compare_results
sven-oly Jan 3, 2025
0e21261
Merge remote-tracking branch 'upstream/main' into compare_results
sven-oly May 1, 2025
5a9f819
more preparation for comparing test sets
sven-oly May 6, 2025
d7522fc
Merge remote-tracking branch 'upstream/main' into compare_results
sven-oly May 9, 2025
caa2b84
Update testreport for comparing test groups
sven-oly May 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion schema/collation/test_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,11 @@
"warning": {
"description": "Present when data has a problem",
"type": "string"
}
},
"hash_id": {
"description": "Has value of the JSON string omtting label value",
"type": "integer"
}
},
"required": [
"label",
Expand Down
4 changes: 4 additions & 0 deletions schema/lang_names/test_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
"locale_label": {
"description": "locale tag of the language being described ",
"type": "string"
},
"hash_id": {
"description": "Has value of the JSON string omtting label value",
"type": "integer"
}
},
"additionalProperties": false
Expand Down
8 changes: 7 additions & 1 deletion schema/likely_subtags/test_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,13 @@
},
"option": {
"description": "Type of processing requested",
"enum": ["maximize", "minimize", "minimizeFavorScript", "minimizeFavorRegion"]
"enum": ["maximize", "minimize",
"minimizeFavorScript",
"minimizeFavorRegion"]
},
"hash_id": {
"description": "Has value of the JSON string omtting label value",
"type": "integer"
}
}
},
Expand Down
4 changes: 4 additions & 0 deletions schema/number_format/test_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@
"default": "auto"
}
}
},
"hash_id": {
"description": "Has value of the JSON string omtting label value",
"type": "integer"
}
},
"required": [
Expand Down
7 changes: 3 additions & 4 deletions schema/schema_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
'collation_test': 'collation',
'datetime_fmt_test_file': 'datetime_fmt',
'datetime_fmt_test': 'datetime_fmt',
'lang_name_test_file': 'lang_names',
'lang_names_test_file': 'lang_names',
'likely_subtags_test': 'likely_subtags',
'list_fmt_test_file': 'list_fmt',
Expand Down Expand Up @@ -96,15 +95,15 @@
"lang_names": {
"test_data": {
"schema_file": "lang_names/test_schema.json",
'prod_file': 'lang_name_test_file.json'
'prod_file': 'lang_names_test_file.json'
},
"verify_data": {
"schema_file": "lang_names/verify_schema.json",
'prod_file': 'lang_name_verify_file.json'
'prod_file': 'lang_names_verify_file.json'
},
"result_data": {
"schema_file": "lang_names/result_schema.json",
"prod_file": "lang_name_test_file.json"
"prod_file": "lang_names_test_file.json"
}
},
"likely_subtags": {
Expand Down
8 changes: 4 additions & 4 deletions testdriver/datasets.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,14 @@ def def_value():

testName = 'display_names'
testDatasets[testName] = DataSet(testType.display_names.value,
'lang_name_test_file.json',
'lang_name_verify_file.json',
'lang_names_test_file.json',
'lang_names_verify_file.json',
CLDRVersion.CLDR41, ICUVersion.ICU71)

testName = 'lang_names'
testDatasets[testName] = DataSet(testType.lang_names.value,
'lang_name_test_file.json',
'lang_name_verify_file.json',
'lang_names_test_file.json',
'lang_names_verify_file.json',
CLDRVersion.CLDR41, ICUVersion.ICU71)

testName = 'likely_subtags'
Expand Down
18 changes: 9 additions & 9 deletions testgen/generators/lang_names.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ def process_test_data(self):
# TODO: add standard vs. dialect vs. alternate names
self.generateLanguageNameTestDataObjects(rawlangnametestdata)
self.generateTestHashValues(self.json_test)
output_path = os.path.join(self.icu_version, "lang_name_test_file.json")
lang_name_test_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_test, lang_name_test_file, indent=1)
lang_name_test_file.close()

output_path = os.path.join(self.icu_version, "lang_name_verify_file.json")
lang_name_verify_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_verify, lang_name_verify_file, indent=1)
lang_name_verify_file.close()
output_path = os.path.join(self.icu_version, "lang_names_test_file.json")
lang_names_test_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_test, lang_names_test_file, indent=1)
lang_names_test_file.close()

output_path = os.path.join(self.icu_version, "lang_names_verify_file.json")
lang_names_verify_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_verify, lang_names_verify_file, indent=1)
lang_names_verify_file.close()

return True

Expand Down
18 changes: 9 additions & 9 deletions testgen/generators/localeDisplayNames.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ def process_test_data(self):
# TODO: add standard vs. dialect vs. alternate names
self.generateLanguageNameTestDataObjects(raw_locale_display_names_testdata)
self.generateTestHashValues(self.json_test)
output_path = os.path.join(self.icu_version, "lang_name_test_file.json")
lang_name_test_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_test, lang_name_test_file, indent=1)
lang_name_test_file.close()

output_path = os.path.join(self.icu_version, "lang_name_verify_file.json")
lang_name_verify_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_verify, lang_name_verify_file, indent=1)
lang_name_verify_file.close()
output_path = os.path.join(self.icu_version, "lang_names_test_file.json")
lang_names_test_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_test, lang_names_test_file, indent=1)
lang_names_test_file.close()

output_path = os.path.join(self.icu_version, "lang_names_verify_file.json")
lang_names_verify_file = open(output_path, "w", encoding="UTF-8")
json.dump(self.json_verify, lang_names_verify_file, indent=1)
lang_names_verify_file.close()

return True

Expand Down
Loading
Loading