CLDR-18253 Add en_TW #4674
Open
CLDR-18253 Add en_TW #4674
+1,151
−482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEApple
requested review from
conradarcturus,
macchiati,
pedberg-icu,
richgillam and
DraganBesevic
AEApple
added a commit
to AEApple/cldr
that referenced
this pull request
May 7, 2025
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
AEApple
added a commit
to AEApple/cldr
that referenced
this pull request
May 8, 2025
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@macchiati @pedberg-icu - I updated the eras based on #4679. Does this look correct to you? |
macchiati
previously approved these changes
May 8, 2025
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@macchiati - I went through even more thoroughly and double checked the data. I had to extrapolate for en_TW from the existing date formats to the other numeric date formats. Can you please re-review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18253
Add en-TW
Add support for calendar type roc in en.xml and en_001.xml
Update eras based on discussion in CLDR-18603 Add GyM, GyMEd availableFormats to root, en #4679
This PR completes the ticket.
ALLOW_MANY_COMMITS=true