Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17532 update max search keywords #3661

Merged

Conversation

macchiati
Copy link
Member

CLDR-17532

Reset the CheckWidths for emoji search keywords. This is a large max, to allow the extra values from https://unicode-org.atlassian.net/browse/CLDR-17349 One-off import of additional Emoji keyword data from WhatsApp into CLDR as part of v46 cycle

After CLDR-17349 has been merged we can fine-tune the values.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati macchiati marked this pull request as ready for review April 30, 2024 03:40
Copy link
Contributor

@cgaarden cgaarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you Mark.

Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM provided we keep the ticket open and fine tune the max values per the PR description.

@macchiati macchiati merged commit 7cf55b1 into unicode-org:main May 1, 2024
10 checks passed
@macchiati
Copy link
Member Author

Agreed, I plan on doing just that.

LTGM provided we keep the ticket open and fine tune the max values per the PR description.

@macchiati macchiati deleted the CLDR-17532-update-max-search-keywords branch May 1, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants