Skip to content

CLDR-11312 Valid HTML #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020
Merged

CLDR-11312 Valid HTML #308

merged 1 commit into from
Feb 11, 2020

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Feb 4, 2020

-Fix some warnings/errors per validator.w3.org

-Remove id for td cells, change styles and selectors to use class instead

-The type attribute for the style element is not needed and should be omitted

-The type attribute is unnecessary for JavaScript resources

-Attribute execute not allowed on element div at this point (in v.jsp)

-Element a not allowed as child of element ul in this context; gear menu ul add li

-The border attribute is obsolete. Specify class border: 0 instead (in iconHtml)

-The aria-labelledby attribute must point to an element; delete attribute

-Duplicate ID stchanged_btn; delete unused id

-Delete superfluous hidden votedcell and errcell

-Delete surveyConfig and theTable.config; use tr.querySelector() instead

-Delete superfluous style for empty Dashboard statuscell

-Delete unused function wrapRadios

-Delete ineffective Close button referencing non-existent function dismissChangeNotice

-Delete superfluous assignment theTable = theDiv.theTable

-Save time by skipping some initialization of theTable when it is re-used

-Avoid id=null, instead use removeAttribute(id) where needed

-Fix stray end tag input and stray end tag td, change latter to th in hidden.html

-An img element must have an alt attribute

-Fix colspan attribute values, 7 not 9; in Dashboard, 5 not 7

-Remove commented-out code

-Comments

Checklist

-Fix some warnings/errors per validator.w3.org

-Remove id for td cells, change styles and selectors to use class instead

-The type attribute for the style element is not needed and should be omitted

-The type attribute is unnecessary for JavaScript resources

-Attribute execute not allowed on element div at this point (in v.jsp)

-Element a not allowed as child of element ul in this context; gear menu ul add li

-The border attribute is obsolete. Specify class border: 0 instead (in iconHtml)

-The aria-labelledby attribute must point to an element; delete attribute

-Duplicate ID stchanged_btn; delete unused id

-Delete superfluous hidden votedcell and errcell

-Delete surveyConfig and theTable.config; use tr.querySelector() instead

-Delete superfluous style for empty Dashboard statuscell

-Delete unused function wrapRadios

-Delete ineffective Close button referencing non-existent function dismissChangeNotice

-Delete superfluous assignment theTable = theDiv.theTable

-Save time by skipping some initialization of theTable when it is re-used

-Avoid id=null, instead use removeAttribute(id) where needed

-Fix stray end tag input and stray end tag td, change latter to th in hidden.html

-An img element must have an alt attribute

-Fix colspan attribute values, 7 not 9; in Dashboard, 5 not 7

-Remove commented-out code

-Comments
@btangmu btangmu self-assigned this Feb 4, 2020
@btangmu
Copy link
Member Author

btangmu commented Feb 4, 2020

LGTM, IMHO. Still I'm making it a "draft" PR to begin, due to the large number and variety of changes. It's probably best for at least a couple reviewers to take a careful look.

Note: travis errors are expected due to unresolved problems with new XML in PR #303

It's OK with me if we wait until those errors are resolved before merging this PR.

@btangmu
Copy link
Member Author

btangmu commented Feb 4, 2020

I just noticed that I made LIMITED_SUBMISSION = false in this PR, which I did for testing but didn't really intend to be part of the PR. Will it be false for v38?

@srl295
Copy link
Member

srl295 commented Feb 5, 2020 via email

@macchiati
Copy link
Member

macchiati commented Feb 5, 2020 via email

@btangmu
Copy link
Member Author

btangmu commented Feb 5, 2020

About the r@, it could be that upgrading jQuery would solve the issue. Anyway it turns out not to be important for this ticket since for the elements that needed changing, we always have the tr already and can get the td by tr.querySelector(class).

I'll go ahead and make this "ready for review" (turn off draft status).

@btangmu btangmu marked this pull request as ready for review February 5, 2020 15:09
@btangmu btangmu merged commit 0b52592 into unicode-org:master Feb 11, 2020
@btangmu btangmu deleted the t11312_c branch February 11, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants