Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16346 Fix initials 2 #2718

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Feb 14, 2023

CLDR-16346

Detect and fix inconsistencies between initial pattern and literals between initial fields. Handles the "J. R.R. Tolkien" case.

From Person Names WG agenda

Overall Recommendations AGREED

  1. For en, en_GB: Switch to J.R.R. Tolkien.
    a. In en, drop space between initial fields, drop space in initial sequence pattern,
    b. In en_GB, en_001, change to ^^^.
  2. For ar, move period to ‘initial’. Was:
    a. {0} R Gillam→R. Gillam
    b. {0}. {1}. R. B. Gillam (same)
  3. For nl, drop the space in the adjacent fields.
    a. Will look like en, en_GB in (i) above
  4. For yue, the sorting forms need spaces, eg
    a. {surname-core}{given-initial}{given2-initial}
    b. The FSR will cause them to be removed or replaced by ·
    c. {surname-core} {given-initial} {given2-initial}

Also adds Check and Test

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that looks like what we discussed.

@btangmu
Copy link
Member

btangmu commented Feb 15, 2023

stuck on "Expected — Waiting for status to be reported"; I'll close and re-open this PR to un-stick it

@btangmu btangmu closed this Feb 15, 2023
@btangmu btangmu reopened this Feb 15, 2023
@macchiati macchiati merged commit 62d07d1 into unicode-org:main Feb 15, 2023
@macchiati
Copy link
Member Author

Ah, that's the magic formula to kick the tests off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants