CLDR-16284 Remove Thai from no-space name scripts #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the commits has the wrong JIRA ticket number, maybe this can be fixed when you squash? |
pedberg-icu
previously approved these changes
Feb 9, 2023
macchiati
force-pushed
the
CLDR-16284-Remove-Thai-from-no-space-name-scripts
branch
from
ef0f82c
to
00f9768
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
btangmu
approved these changes
Feb 9, 2023
richgillam
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
I take it you're getting the list of scripts that don't use spaces from some other resources in CLDR and then modifying it to exclude Thai? Because if this is the only place where that information lives, you could just take Thai out of the list and be done with it.
|
Right.
…On Thu, Feb 9, 2023 at 1:54 PM Rich Gillam ***@***.***> wrote:
***@***.**** approved this pull request.
I take it you're getting the list of scripts that don't use spaces from
some other resources in CLDR and then modifying it to exclude Thai? Because
if this is the only place where that information lives, you could just take
Thai out of the list and be done with it.
—
Reply to this email directly, view it on GitHub
<#2704 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEME7VAYL2JIM6ZVHIX3WWVRQHANCNFSM6AAAAAAUV3IHAY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
macchiati
deleted the
CLDR-16284-Remove-Thai-from-no-space-name-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-16284
Removing Thai from the list of scripts that don't need spaces in names.
ALLOW_MANY_COMMITS=true