CLDR-15071 Fix dtd tests #2702
Merged
CLDR-15071 Fix dtd tests #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
previously approved these changes
Feb 8, 2023
common/dtd/ldml.dtd
Outdated
| @@ -2825,10 +2826,11 @@ CLDR data files are interpreted according to the LDML specification (http://unic | |||
|
|
|||
| <!ELEMENT cr ( #PCDATA ) > | |||
| <!ATTLIST cr alt NMTOKENS #IMPLIED > | |||
| <!--@MATCH:literal/variant--> | |||
| <!--@MATCH:literal/variant, proposed--> | |||
There was a problem hiding this comment.
Yes, the changes in the test exposed some gaps.
srl295
previously approved these changes
Feb 8, 2023
srl295
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-15071
I noticed that the tests were not catching a mismatch between the sil1 value in the .xml file and the sil22 value in the dtd. I looked into it, and found some problems in the test, where paths not being tested correctly. Fixed those, and the cases in the DTD that they exposed.
ALLOW_MANY_COMMITS=true